Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(packages/sui-bundler): add flag for creating libs with css chunks #1738

Open
wants to merge 666 commits into
base: master
Choose a base branch
from
Open

feat(packages/sui-bundler): add flag for creating libs with css chunks #1738

wants to merge 666 commits into from

Conversation

NietoGX
Copy link

@NietoGX NietoGX commented Mar 14, 2024 •
edited
Loading

Description

This PR adds an option to the sui-bundler build lib for generating CSS chunks.

By default the code will not use chunks for the css. With the option --chunk-css will use the css with chunks.

Example

sui-bundler lib umd/index.js -o umd/ --root --chunk-css will generate a chunk for each css file.
For example, if we want to select a different scss file from the js with code like:

switch (site) {
    case 'fotocasa':
      import('./fotocasa.scss')
      break
    case 'cochesnet':
      import('./motor.scss')
      break
    case 'motosnet':
      import('./motor.scss')
      break
    case 'milanuncios':
      import('./milanuncios.scss')
      break
    case 'infojobs':
      import('./milanuncios.scss')
      break
    default:
      import('./index.scss')
  }

The sui-bundler will generate the next files:

image

oriolpuig and others added 26 commits July 2, 2024 13:40
@oriolpuig
feat(packages/sui-lint): Add sui/decorator-async-inline-error rule to…
6294dd8 
… domain package
@oriolpuig
chore(Root): Update package-lock
fe8b7f5
@oriolpuig
docs(packages/sui-decorators): Add documentation for new @AsyncInline…
bee8cb2 
…Error()
@oriolpuig
feat(packages/sui-decorators): @inlineError - Add warning to avoid us…
d997ff7 
…age on async functions
@oriolpuig
feat(packages/eslint-plugin-sui): Create new rule for decorator-inlin…
6124f6b 
…e-error
@oriolpuig
feat(packages/sui-lint): Add new decorator-inline-error to domain pac…
3d7d977 
…kages
@jordevo
feat(packages/eslint-plugin-sui): rephrase message for inlineErrorMis…
c0d8b2e 
…place rule
@jordevo
Merge pull request #1784 from SUI-Components/feat-eslint-plugin-sui-i…
c0e1abc 
…nline-error-decorator-message

feat(packages/eslint-plugin-sui): rephrase message for inlineErrorMissplace rule
@sui-bot
release(packages/eslint-plugin-sui): v1.9.0 [skip ci]
c699721
@oriolpuig
feat(packages/sui-decorators): Create new @deprecated() decorator
9ebc5af
@oriolpuig
feat(packages/eslint-plugin-sui): @inlineError must be on non-async f…
163a959 
…unctions and closest to the met
@oriolpuig
refactor(packages/eslint-plugin-sui): Clean @AsyncInlineError decorat…
ef3c679 
…or lint rules
feat(packages/sui-polyfills): Added polyfills for Array.prototype.at,…
4529691 
… Promise.allSettled and Promise
@ferransimon
Merge pull request #1786 from SUI-Components/feature/addMissingPolyfills
8e23b37 
feat(packages/sui-polyfills): Added polyfills
@sui-bot
release(packages/sui-polyfills): v1.22.0 [skip ci]
22e6f88
@dependabot
upgrade(deps): bump @pactflow/pact-msw-adapter from 2.0.0 to 2.0.1
6d567b7 
Bumps [@pactflow/pact-msw-adapter](https://github.com/pactflow/pact-msw-adapter) from 2.0.0 to 2.0.1.
- [Release notes](https://github.com/pactflow/pact-msw-adapter/releases)
- [Changelog](https://github.com/pactflow/pact-msw-adapter/blob/main/CHANGELOG.md)
- [Commits](pactflow/pact-msw-adapter@v2.0.0...v2.0.1)

---
updated-dependencies:
- dependency-name: "@pactflow/pact-msw-adapter"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@nucliweb
Update README.md
faca9bc
@oriolpuig
feat(packages/eslint-plugin-sui): Create rules for @deprecated() deco…
aa22a8d 
…rator
@oriolpuig
feat(packages/eslint-plugin-sui): Make decorator-deprecated-remark-me…
5b9ee47 
…thod runs on classes
@oriolpuig
feat(packages/eslint-plugin-sui): Make deprecated-decorator rules run…
ec08bf4 
…ning on Classes, Methods and Ar
@andresz1
feat(packages/sui-performance): add performance package
026e5b6
@andresz1
feat(packages/sui-performance): documentation and tests
10b8569
@andresz1
docs(packages/sui-performance): improve docs
bcf5250
@andresz1
Merge pull request #1794 from SUI-Components/feat/performance
4ca18ab 
feat(packages/sui-performance): add performance package
@sui-bot
release(packages/sui-performance): v1.1.0 [skip ci]
eefa0ae
@andresz1
feat(packages/sui-performance): move queue
b066902
andresz1 and others added 29 commits October 15, 2024 11:41
@andresz1
Merge pull request #1843 from SUI-Components/fix/pde-consents
beb8462 
feat(packages/sui-pde): avoid sending impression when consents are not accepted
@sui-bot
release(packages/sui-pde): v2.29.0 [skip ci]
356ed14
feat(packages/lint-repository-sui): Add jest adoption rule to lint
b631c23
feat(packages/sui-lint): Add jest adoption rule to @s-ui/lint
4f023a9
@jelowin
Merge pull request #1844 from SUI-Components/feat/jest-adoption-rule
88a066e 
feat(packages/lint-repository-sui): Add jest adoption rule to lint
@sui-bot
release(packages/lint-repository-sui): v1.13.0 [skip ci]
8064757
@jelowin
Merge pull request #1845 from SUI-Components/feat/add-jest-adoption-rule
8774e70 
feat(packages/sui-lint): Add jest adoption rule to @s-ui/lint repository config
@sui-bot
release(packages/sui-lint): v4.51.0 [skip ci]
67647e8
@nucliweb
refactor(packages/sui-logger): add missed Trackers in client and serv…
4106c99 
…er level
@nucliweb
Merge pull request #1846 from SUI-Components/feat/sui-logger
0cf7fa0 
refactor(packages/sui-logger): add missed Trackers in client and server level
@sui-bot
release(packages/sui-logger): v1.4.0 [skip ci]
cbe1b95
@carlosvillu
feat(packages/sui-decorators): remove console.log
206dd74
@carlosvillu
Merge pull request #1847 from SUI-Components/remove-decorator-log
8966eab 
feat(packages/sui-decorators): remove console.log
@sui-bot
release(packages/sui-decorators): v3.29.0 [skip ci]
12fd0f7
@andresz1
feat(packages/sui-bundler): add tailwind support
46949d8
@andresz1
feat(packages/sui-bundler): update tailwindcss call
e0dd668
@andresz1
feat(packages/sui-bundler): add tailwindcss to client dev
ce7c945
@andresz1
feat(Root): update lock file
6f1c9c2
@andresz1
feat(packages/sui-bundler): lint issue
a92c1cc
@andresz1
Merge pull request #1593 from SUI-Components/feat/add-tailwind
07eab2f 
feat(packages/sui-bundler): add tailwind support
@sui-bot
release(packages/sui-bundler): v9.67.0 [skip ci]
ad29323
@andresz1
feat(packages/sui-bundler): add experimental spritemaps
b2c8feb
@andresz1
feat(packages/sui-bundler): update documentation
5da6feb
@andresz1
feat(packages/sui-bundler): update api
e25b96e
@andresz1
docs(packages/sui-pde): fix typo
56397fd
@andresz1
Merge pull request #1849 from SUI-Components/feat/experimental-sprite…
b108712 
…maps

feat(packages/sui-bundler): add experimental spritemaps
@sui-bot
release(packages/sui-bundler): v9.68.0 [skip ci]
9442251
@andresz1
Merge pull request #1850 from SUI-Components/fix/pde-doc-typo
23933a4 
docs(packages/sui-pde): fix typo
@carlosvillu
Merge branch 'feat/use-chunks-in-umd-css' of github.com:SUI-Component…
4ab07e2 
…s/sui into feat/use-chunks-in-umd-css
@carlosvillu carlosvillu mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikoruiz kikoruiz kikoruiz approved these changes

@sui-bot sui-bot Awaiting requested review from sui-bot sui-bot is a code owner

@andresz1 andresz1 Awaiting requested review from andresz1 andresz1 is a code owner

@carlosvillu carlosvillu Awaiting requested review from carlosvillu carlosvillu is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.